ext/pgsql: pgsql_copy_from to support iterable. #16124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspired from the Pdo\Pgsql new feature phpGH-15893.
devnexen
force-pushed
the
pgsql_copy_from_iterable
branch
from
7dd144c to
1eef6df
Compare
Girgias
requested changes
Oct 1, 2024
ext/pgsql/pgsql.c
Outdated
| @@ -3376,7 +3400,7 @@ PHP_FUNCTION(pg_copy_from) | |||
| ZEND_PARSE_PARAMETERS_START(3, 5) | |||
| Z_PARAM_OBJECT_OF_CLASS(pgsql_link, pgsql_link_ce) | |||
| Z_PARAM_PATH_STR(table_name) | |||
| Z_PARAM_ARRAY(pg_rows) | |||
| Z_PARAM_ARRAY_OR_OBJECT(pg_rows) | |||
ext/pgsql/pgsql.c
Outdated
| } | ||
| } ZEND_HASH_FOREACH_END(); | ||
| } else { | ||
| zend_object_iterator *iter = Z_OBJ_P(pg_rows)->ce->get_iterator(Z_OBJCE_P(pg_rows), pg_rows, 0); |
There was a problem hiding this comment.
Suggested change
| zend_object_iterator *iter = Z_OBJ_P(pg_rows)->ce->get_iterator(Z_OBJCE_P(pg_rows), pg_rows, 0); | |
| zend_object_iterator *iter = Z_OBJCE_P(pg_rows)->get_iterator(Z_OBJCE_P(pg_rows), pg_rows, 0); |
ext/pgsql/pgsql.stub.php
Outdated
| @@ -847,7 +847,7 @@ function pg_put_line($connection, string $query = UNKNOWN): bool {} | |||
| */ | |||
| function pg_copy_to(PgSql\Connection $connection, string $table_name, string $separator = "\t", string $null_as = "\\\\N"): array|false {} | |||
|
|
|||
| function pg_copy_from(PgSql\Connection $connection, string $table_name, array $rows, string $separator = "\t", string $null_as = "\\\\N"): bool {} | |||
| function pg_copy_from(PgSql\Connection $connection, string $table_name, array|object $rows, string $separator = "\t", string $null_as = "\\\\N"): bool {} | |||
There was a problem hiding this comment.
Suggested change
| function pg_copy_from(PgSql\Connection $connection, string $table_name, array|object $rows, string $separator = "\t", string $null_as = "\\\\N"): bool {} | |
| function pg_copy_from(PgSql\Connection $connection, string $table_name, array|Traversable $rows, string $separator = "\t", string $null_as = "\\\\N"): bool {} |
|
The changes will need to be applied to #15893 |
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Oct 1, 2024
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Oct 1, 2024
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
inspired from the Pdo\Pgsql new feature phpGH-15893. close phpGH-16124
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
inspired from the Pdo\Pgsql new feature phpGH-15893. close phpGH-16124
devnexen
added a commit
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired from the Pdo\Pgsql new feature GH-15893.